Skip to content

Patch pprint to make pytest diffs nicer for big objects#92

Merged
samuelcolvin merged 13 commits intosamuelcolvin:mainfrom
alexmojaki:pprint
Aug 12, 2024
Merged

Patch pprint to make pytest diffs nicer for big objects#92
samuelcolvin merged 13 commits intosamuelcolvin:mainfrom
alexmojaki:pprint

Conversation

@alexmojaki
Copy link
Copy Markdown
Contributor

@alexmojaki alexmojaki commented Nov 14, 2023

Replaces alexmojaki#1

Closes #73

@alexmojaki
Make datetime tests pass without requiring UTC system timezone
cd4600d 
Sets the timezone in the tests, and uses the timezone of approx to convert from unix number
@alexmojaki
Pass absolute paths to find_examples so that tests don't rely on cwd
249435b 
This makes it easier to run the tests in my IDE
@alexmojaki
Use same version of platformdirs in all requirements/*.txt files
6bb7f1a
@alexmojaki
revert changes to datetime and test_datetime
b3b6ba0
@alexmojaki
set TZ=utc in make test since some tests require it
700f68e
@alexmojaki
Patch pprint to make pytest diffs nicer for big objects
0208c6e
@alexmojaki
comments
0b49fe8
@alexmojaki
inline check_repr_pformat
c691b88
@alexmojaki
Merge branch 'main' of github.com:samuelcolvin/dirty-equals into pprint
9221726
@alexmojaki
Merge branch 'main' of github.com:samuelcolvin/dirty-equals into pprint
dcca319
@alexmojaki
fix merge
d180ac3
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Merging #92 (f76edaa) into main (78a9922) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          814       822    +8     
  Branches       150       153    +3     
=========================================
+ Hits           814       822    +8
Files Coverage Δ
dirty_equals/_base.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a9922...f76edaa. Read the comment docs.

@alexmojaki
Copy link
Copy Markdown
Contributor Author

alexmojaki commented Nov 14, 2023

ready to review

@samuelcolvin
Copy link
Copy Markdown
Owner

samuelcolvin commented Nov 15, 2023

LGTM, please can you add an screenshot or similar example to PR showing how this improves the display?

@alexmojaki
Copy link
Copy Markdown
Contributor Author

alexmojaki commented Nov 15, 2023

As in the original issue, before:

E       AssertionError: assert (['ddsdsdads ', 'sfafsdsd', 'dfds sdfsef', 'sfdssdf ', 'sdsadfs', 'dsfsdfsd', 'cfdfdfd', 'dgffgfdgfd', 'fdsfsdgfsdgsf'], 1, 2, 3, 4, 5, 6, 7, 8, 9) == (['ddsdsdads ', 'sfafsdsd', 'dfds sdfsef', 'sfdssdf ', 'sdsadfs', 'dsfsdfsd', 'cfdfdfd', 'dgffgfdgfd', 'fdsfsdgfsdgsf'], 1, 2, 3, 4, 5, 6, 7, 8, 0)
E         At index 9 diff: 9 != 0
E         Full diff:
E           (
E         -  ['ddsdsdads ', 'sfafsdsd', 'dfds sdfsef', 'sfdssdf ', 'sdsadfs', 'dsfsdfsd', 'cfdfdfd', 'dgffgfdgfd', 'fdsfsdgfsdgsf'],
E         +  ['ddsdsdads ',
E         +   'sfafsdsd',
E         +   'dfds sdfsef',
E         +   'sfdssdf ',
E         +   'sdsadfs',
E         +   'dsfsdfsd',
E         +   'cfdfdfd',
E         +   'dgffgfdgfd',
E         +   'fdsfsdgfsdgsf'],
E            1,
E            2,
E            3,
E            4,
E            5,
E            6,
E            7,
E            8,
E         -  0,
E         +  9,
E           )

After:

E       AssertionError: assert (['ddsdsdads ', 'sfafsdsd', 'dfds sdfsef', 'sfdssdf ', 'sdsadfs', 'dsfsdfsd', 'cfdfdfd', 'dgffgfdgfd', 'fdsfsdgfsdgsf'], 1, 2, 3, 4, 5, 6, 7, 8, 9) == (['ddsdsdads ', 'sfafsdsd', 'dfds sdfsef', 'sfdssdf ', 'sdsadfs', 'dsfsdfsd', 'cfdfdfd', 'dgffgfdgfd', 'fdsfsdgfsdgsf'], 1, 2, 3, 4, 5, 6, 7, 8, 0)
E         At index 9 diff: 9 != 0
E         Full diff:
E           (
E            ['ddsdsdads ',
E             'sfafsdsd',
E             'dfds sdfsef',
E             'sfdssdf ',
E             'sdsadfs',
E             'dsfsdfsd',
E             'cfdfdfd',
E             'dgffgfdgfd',
E             'fdsfsdgfsdgsf'],
E            1,
E            2,
E            3,
E            4,
E            5,
E            6,
E            7,
E            8,
E         -  0,
E         +  9,
E           )

@alexmojaki
Copy link
Copy Markdown
Contributor Author

alexmojaki commented Feb 28, 2024

This problem threw me off today, please can this be merged?

@samuelcolvin samuelcolvin merged commit 2ce5fab into samuelcolvin:main Aug 12, 2024
@samuelcolvin
Copy link
Copy Markdown
Owner

samuelcolvin commented Aug 12, 2024

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

objects with multiline repr cause pytest to print a diff

2 participants

@alexmojaki @samuelcolvin